RFR: 8146001: Remove support for command line options from JVMCI
Christian Thalinger
christian.thalinger at oracle.com
Mon Jan 4 17:16:59 UTC 2016
> On Dec 22, 2015, at 4:50 AM, Doug Simon <doug.simon at oracle.com> wrote:
>
> The effort of maintaining JVMCI across different JDK versions (including a potential backport to JDK7) is reduced by making JVMCI as small as possible. The support for command line options in JVMCI (based around the @Option annotation) is a good candidate for removal:
>
> 1. It’s almost entirely implemented on top of system properties and so can be made to work without VM support.
> 2. JVMCI itself only currently uses 3 options which can be replaced with usage of sun.misc.VM.getSavedProperty(). The latter ensures application code can’t override JVMCI properties set on the command line.
>
> This change removes the JVMCI command line option support.
>
> https://bugs.openjdk.java.net/browse/JDK-8146001
> http://cr.openjdk.java.net/~dnsimon/8146001/
+ private static final boolean TrustFinalDefaultFields = HotSpotJVMCIRuntime.getBooleanProperty(TrustFinalDefaultFieldsProperty, true);
+ private static final boolean ImplicitStableValues = HotSpotJVMCIRuntime.getBooleanProperty("jvmci.ImplicitStableValues", true);
We should either use the jvmci. prefix or not.
src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethod.java:
- @Option(help = "", type = OptionType.Debug)
- public static final OptionValue<Boolean> UseProfilingInformation = new OptionValue<>(true);
We are using this flag so we need to keep it.
>
> -Doug
More information about the hotspot-compiler-dev
mailing list