RFR: 8146364: Remove @ServiceProvider mechanism from JVMCI

Christian Thalinger christian.thalinger at oracle.com
Tue Jan 12 01:35:28 UTC 2016


> On Jan 11, 2016, at 12:43 PM, Doug Simon <doug.simon at oracle.com> wrote:
> 
> Hi,
> 
> Please review these changes for removing the mechanism in JVMCI for automating the generation of files in META-INF/services for service providers annotated with @ServiceProvider.

Did you try this with a regular JDK 9 build?  I don’t think it works to have the same META-INF file in different locations:

src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/META-INF/services/jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory
src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/META-INF/services/jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory
src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/META-INF/services/jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory

They will overwrite each other when being installed into the image.

> 
> https://bugs.openjdk.java.net/browse/JDK-8146364
> 
> http://cr.openjdk.java.net/~dnsimon/8146364/jdk9/ 
> http://cr.openjdk.java.net/~dnsimon/8146364/hotspot/
> 
> -Doug



More information about the hotspot-compiler-dev mailing list