RFR: 8146364: Remove @ServiceProvider mechanism from JVMCI

[Christian Thalinger]

> On Jan 11, 2016, at 11:39 PM, Doug Simon <doug.simon at oracle.com> wrote:
> 
> Doh! This was a result of pilot error when transplanting patches from graal-jvmci-9. I left out:
> 
> http://hg.openjdk.java.net/graal/graal-jvmci-9/hotspot/rev/2390bc159b77
> 
> The behavior I saw was not that the META-INF files overwrote each other. Instead, they were ignored completely.
> 
> I’ve updated http://cr.openjdk.java.net/~dnsimon/8146364/hotspot/ now.

Yes, that looks better.

> 
> -Doug
> 
>> On 12 Jan 2016, at 02:35, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> 
>> 
>>> On Jan 11, 2016, at 12:43 PM, Doug Simon <doug.simon at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> Please review these changes for removing the mechanism in JVMCI for automating the generation of files in META-INF/services for service providers annotated with @ServiceProvider.
>> 
>> Did you try this with a regular JDK 9 build?  I don’t think it works to have the same META-INF file in different locations:
>> 
>> src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/META-INF/services/jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory
>> src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/META-INF/services/jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory
>> src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/META-INF/services/jdk.vm.ci.hotspot.HotSpotJVMCIBackendFactory
>> 
>> They will overwrite each other when being installed into the image.
>> 
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8146364
>>> 
>>> http://cr.openjdk.java.net/~dnsimon/8146364/jdk9/ 
>>> http://cr.openjdk.java.net/~dnsimon/8146364/hotspot/
>>> 
>>> -Doug
>> 
>