[9] RFR(XS): 8147444: compiler/jsr292/NonInlinedCall/RedefineTest.java fails with NullPointerException in ClassFileInstaller

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Fri Jan 15 12:40:02 UTC 2016


Looks good. Thanks for fixing it!

BTW can ClassFileInstaller be improved to check the input and report the 
problem in a meaningful way? NPE is useless when diagnosing such problems.

Best regards,
Vladimir Ivanov

On 1/15/16 2:07 PM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch:
>
> https://bugs.openjdk.java.net/browse/JDK-8147444
> http://cr.openjdk.java.net/~thartmann/8147444/webrev.00/
>
> The test compiler/jsr292/NonInlinedCall/RedefineTest.java fails in the ClassFileInstaller while trying to install jdk.test.lib.Asserts because the class is not imported and therefore not compiled. Because asserts are not used in this test, I removed the directive.
>
> Thanks,
> Tobias
>


More information about the hotspot-compiler-dev mailing list