RFR (S): 8145800: [Testbug] CompilerControl: inline message differs for not inlined methods

Pavel Punegov pavel.punegov at oracle.com
Wed Jan 20 17:23:33 UTC 2016


Thanks for review, Vladimir.

> On 20 Jan 2016, at 19:49, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Good.
> Thanks,
> Vladimir
> 
> On 1/20/16 8:36 AM, Pavel Punegov wrote:
>> Hi,
>> 
>> please review the following fix for the test bug.
>> 
>> Issue: tests incorrectly set inlining state for methods, that belong to any of Internal subclass of both pool.sub.Klass
>> and pool.subpack.KlassDup.
>> This happen because test have an assumption that any of method callers will match only *.* directive pattern. But they
>> could match patterns like “*Internal*”, because
>> a typical method caller in this case could be pool/sub/Klass$Internal::lambda$getAllMethods$0.
>> 
>> Fix: Make method callers (lambdas) do not contain any names used in the test, such as Internal, or Klass. That’s why all
>> executable and callable creation was moved to a new SubMethodHolder class.
>> 
>> bug id: https://bugs.openjdk.java.net/browse/JDK-8145800
>> webrev: http://cr.openjdk.java.net/~ppunegov/8145800/webrev.00/
>> 
>> — Thanks,
>> Pavel Punegov
>> 



More information about the hotspot-compiler-dev mailing list