RFR and workflow question

Christian Thalinger christian.thalinger at oracle.com
Thu Jan 21 02:56:58 UTC 2016


> On Jan 20, 2016, at 6:46 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Use 8147475 for commit message - your change can be related (relocation info could be affected by padding).
> But I don't see how your change can fix 8146608 - it is patching return PC which is SP relative and nothing to do with padding in prolog.
> 
> Changes looks fine. Please, integrate it first since it affect all hotspot repos.

Roland is not a Committer yet; just Author.  I’ll take care of it.

> 
> Thanks,
> Vladimir
> 
> On 1/20/16 7:28 AM, Roland Schatz wrote:
>> Hi!
>> 
>> Please review this small bugfix:
>> http://cr.openjdk.java.net/~rschatz/JDK-8147475/webrev.00/
>> 
>> This is on top of another webrev[1]. It has no semantic dependency on it, just a random source-level conflict. I can
>> rebase them if we want to integrate this one first.
>> 
>> 
>> This is missing a commit message, and I'm not sure what to use here.
>> 
>> There are two issues that I *think* this will solve, but I can't be sure since I haven't managed to reproduce them:
>> https://bugs.openjdk.java.net/browse/JDK-8147475
>> https://bugs.openjdk.java.net/browse/JDK-8146608
>> 
>> Do I just use one of the above issues randomly for the commit message, and close the other as duplicate?
>> 
>> 
>> Thanks,
>> Roland
>> 
>> [1] http://cr.openjdk.java.net/~rschatz/JDK-8147599/webrev.00/



More information about the hotspot-compiler-dev mailing list