[9] RFR(XS): 8147876: ciTypeFlow::is_dominated_by() writes outside dominated array

Tobias Hartmann tobias.hartmann at oracle.com
Mon Jan 25 14:27:40 UTC 2016


Thanks, Nils!

Best,
Tobias

On 25.01.2016 15:12, Nils Eliasson wrote:
> Looks good.
> 
> Best regards,
> Nils
>  (Not a reviewer)
> 
> On 2016-01-25 10:48, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8147876
>> http://cr.openjdk.java.net/~thartmann/8147876/webrev.00/
>>
>> ciTypeFlow::is_dominated_by() write outside the 'dominated' array because it's size is too small. The problem is that the number of ciBlocks is not equal to the Blocks used by ciTypeFlow (there is a 1:n relation). Therefore, we should use block_count() instead of _methodBlocks->num_blocks().
>>
>> Thanks,
>> Tobias
> 


More information about the hotspot-compiler-dev mailing list