[9] RFR(XS): 8147876: ciTypeFlow::is_dominated_by() writes outside dominated array
Vladimir Kozlov
vladimir.kozlov at oracle.com
Mon Jan 25 17:12:06 UTC 2016
Looks good.
Note to all. When you find problem in recent changes, please, add link
in bug report to original changes (JDK-8140574 in this case). In a
future it will help, for example, if we want to backport a original changes.
Thanks,
Vladimir
On 1/25/16 1:48 AM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch:
>
> https://bugs.openjdk.java.net/browse/JDK-8147876
> http://cr.openjdk.java.net/~thartmann/8147876/webrev.00/
>
> ciTypeFlow::is_dominated_by() write outside the 'dominated' array because it's size is too small. The problem is that the number of ciBlocks is not equal to the Blocks used by ciTypeFlow (there is a 1:n relation). Therefore, we should use block_count() instead of _methodBlocks->num_blocks().
>
> Thanks,
> Tobias
>
More information about the hotspot-compiler-dev
mailing list