[9] RFR (XS): 8160360: Mismatched field loads are folded in LoadNode::Value

Tobias Hartmann tobias.hartmann at oracle.com
Mon Jul 4 07:24:13 UTC 2016


Hi Vladimir,

your fix looks good to me.

Best regards,
Tobias

On 01.07.2016 14:30, Vladimir Ivanov wrote:
> Any reviews, please?
> 
> Best regards,
> Vladimir Ivanov
> 
> On 6/29/16 3:52 PM, Vladimir Ivanov wrote:
>> http://cr.openjdk.java.net/~vlivanov/8160360/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8160360
>>
>> Mismatched access check is absent for fields in LoadNode::Value().
>>
>> The fix adds missing check.
>>
>> Also, marked all "wide" on-heap accesses as mismatched. It's possible
>> the type is narrowed later (e.g., during post-parse/incremental
>> inlining) and becomes mismatched.
>>
>> Testing: failing tests, JPRT, PIT (hs-tier0-comp).
>>
>> Best regards,
>> Vladimir Ivanov


More information about the hotspot-compiler-dev mailing list