JDK-8160748: inconsistent types for ideal_reg

[Vladimir Kozlov]

Good cleanup. We should have done it long ago.
But you missed .ad files where Matcher methods are defined.

And you need FC Extension Request since JDK-8160748 is Enhancement.

After the push may need to file the backport for JDK 8u to keep sources  
in sync (a lot of C2 files changed).

Thanks,
Vladimir

On 7/3/16 7:54 AM, Yasumasa Suenaga wrote:
> Hi all,
>
> We've worked for JDK-8160353 to resolve narrowing conversion error at
> GCC 6.
> ------------
> /home/ysuenaga/OpenJDK/hs/hotspot/src/share/vm/opto/type.cpp:101:1:
> error: narrowing conversion of '(uint)Node::NotAMachineReg' from 'uint
> {aka unsigned int}' to 'int' inside { } [-Werror=narrowing]
>  };
>  ^
> /home/ysuenaga/OpenJDK/hs/hotspot/src/share/vm/opto/type.cpp:101:1:
> error: narrowing conversion of '(uint)Node::NotAMachineReg' from 'uint
> {aka unsigned int}' to 'int' inside { } [-Werror=narrowing]
> /home/ysuenaga/OpenJDK/hs/hotspot/src/share/vm/opto/type.cpp:101:1:
> error: narrowing conversion of '(uint)Node::NotAMachineReg' from 'uint
> {aka unsigned int}' to 'int' inside { } [-Werror=narrowing]
> cc1plus: all warnings being treated as errors
> ------------
>
> Opcodes is defined as enum.
> However, a part of code (e.g. NotAMachineReg) is defined as uint.
>
> I think Opcodes related code should consist uint type.
>
>   http://cr.openjdk.java.net/~ysuenaga/JDK-8160748/webrev.00/
>
> I've uploaded webrev for this issue.
> I fixed Opcodes type to uint at first, and fixed many errors with GCC 6.
>
> I want to discuss about this.
>
>
> Thanks,
>
> Yasumasa
>
>