[9] RFR(M): 8151280: update hotspot tests to use vm.compMode instead of their own logic

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Jul 5 23:08:45 UTC 2016


Looks good.

TestEscapeThroughInvoke.java - empty webrev (spacing changes?)

Thanks,
Vladimir

On 6/30/16 9:17 AM, Tatiana Pivovarova wrote:
> Hello,
>
> could you please review this patch?
>
> This review request covers two bugs:
>  - 8151280: update hotspot tests to use vm.compMode instead of their own
> logic [1]
>  - 8145848: Update hs compiler tests to get VM mode using j.t.l.Platform [2]
> Also it relays on bug fix for 8132919 [3] which I posted recently [4]
>
> Summary:
> it's possible now to rely on @requires expressions to choose vm.compMode
> At the moment several compiler tests parse java.vm.info property to get
> VM mode. It could be done using j.t.l.Platform.
>
> This patch has been contributed by Igor Ignatyev.
>
> Tested on on Linux-x86 and Solaris sparc
>
> top level webrev:
> http://cr.openjdk.java.net/~iignatyev/8145848/top/webrev.00/
> hotspot webrev:
> http://cr.openjdk.java.net/~iignatyev/8145848/hotspot/webrev.00/
> bugs: [1] [2]
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8151280
> [2] https://bugs.openjdk.java.net/browse/JDK-8145848
> [3] https://bugs.openjdk.java.net/browse/JDK-8132919
> [4]
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-June/023599.html
>
> Thanks,
> Tatiana


More information about the hotspot-compiler-dev mailing list