[9] RFR(M): 8132919: use package in compiler tests

[Tatiana Pivovarova]

Hi Dmitrij

Thanks for your careful review!

On 07/04/2016 10:25 PM, Dmitrij Pochepko wrote:
> Hi,
>
> 1) a question about 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/make/test/JtregNative.gmk.udiff.html:
> why test/compiler/native is removed from native compilation? I see 
> native file there.
these tests were ranamed
     test/compiler/calls/TestDirtyInt.java (was 
test/compiler/native/TestDirtyInt.java)
     test/compiler/calls/libTestDirtyInt.c (was 
test/compiler/native/libTestDirtyInt.c)

and I fixed 2)-6) comments

new webrev: http://cr.openjdk.java.net/~tpivovarova/8132919/webrev.00/


Thanks,
Tatiana
>
> 2) misprint in package name at 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/test/compiler/controldependency/TestEliminatedCastPPAtPhi.java.udiff.html
> + * compiler.controldependenc.TestEliminatedCastPPAtPhi
> should be "compiler.controldependency.TestEliminatedCastPPAtPhi"
>
> 3) wrong package name at 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/test/compiler/dependencies/MonomorphicObjectCall/TestMonomorphicObjectCall.java.udiff.html
> + * 
> -XX:CompileCommand=compileonly,compiler.dependencies.TestMonomorphicObjectCall::callFinalize 
>
> should be 
> "XX:CompileCommand=compileonly,compiler.dependencies.MonomorphicObjectCall.TestMonomorphicObjectCall::callFinalize" 
>
>
> 4) 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/test/compiler/intrinsics/unsafe/HeapByteBufferTest.java.udiff.html 
> has misprint in converting copyright(year 200 instead of 2000) from 
> set of single line comments to multiline comment.
>
> 5) 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/test/compiler/loopopts/TestCastIINoLoopLimitCheck.java.udiff.html
> compile command contains wrong package name:
> + * 
> -XX:CompileCommand=compileonly,compiler.loopopt.TestCastIINoLoopLimitCheck::m
> should be 
> "-XX:CompileCommand=compileonly,compiler.loopopts.TestCastIINoLoopLimitCheck::m"
>
> 6) 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/test/compiler/rangechecks/TestUncommonTrapMerging.java.udiff.html
> CompileCommand compileonly argument contains test class name without 
> package (both commands)
>
> 7) 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/test/compiler/whitebox/DeoptimizeMultipleOSRTest.java.udiff.html
> CompileCommand compileonly argument contains test class name without 
> package
>
> 8) 
> http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/test/compiler/c2/Test6443505.java.udiff.html
> + * -XX:CompileCommand=compiler.c2.Test6443505::compiled
> probably should be 
> "-XX:CompileCommand=compileonly,compiler.c2.Test6443505::compiled"
>
> Thanks,
> Dmitrij
>
>> Hello,
>>
>> please review this patch
>>
>> Summary:
>> Many hotspot tests and test libraries don't have package. It 
>> complicates test development process in IDE and makes it inconvenient 
>> to use a library.
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev/8132919/webrev.01/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8132919
>>
>> Tested on all platforms.
>>
>> This patch has been contributed by Igor Ignatyev.
>>
>> Thanks,
>> Tatiana
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160706/a8c767cd/attachment.html>