RFR(S): 8159368: [JVMCI] SPARCHotSpotRegisterConfig.callingConvention gives incorrect calling convention for native calls containing fp args

Stefan Anzinger stefan.anzinger at oracle.com
Wed Jul 6 18:20:03 UTC 2016


Hi Vladimir,

sorry for the inconvenience. I haven't expected that much changes inbetween.

Here is the updated patch: 
http://cr.openjdk.java.net/~sanzinger/8159368/webrev.03
This is based and tested on 4be0cada20ad

Stefan

On 07/06/2016 12:50 AM, Vladimir Kozlov wrote:
> Hi Stefan,
>
> webrev.03 patch does not apply to latest hs-comp/hotspot sources. Can 
> you update it?
>
> Thanks,
> Vladimir
>
> On 6/17/16 12:14 AM, Stefan Anzinger wrote:
>> Thank you, Igor.
>>
>> I've updated a webrev with the header in the .c file:
>> http://cr.openjdk.java.net/~sanzinger/8159368/webrev.02/
>> The change is best applied on top of 8159167: [JVMCI] fix
>> HotSpotVMConfig startup performance
>>
>> Thank you
>> Stefan
>>
>> On 06/16/2016 05:03 PM, Igor Veresov wrote:
>>> The .c file probably needs a copyright header. Otherwise looks good.
>>>
>>> igor
>>>
>>>> On Jun 16, 2016, at 4:54 AM, Stefan Anzinger 
>>>> <stefan.anzinger at oracle.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> we found a bug in the JVMCI defined SPARC calling convention when
>>>> calling native methods with single float arguments. Previously the
>>>> HotSpot Calling Convention was used, which is different to the one
>>>> defined in the native ABI [1].
>>>>
>>>> This fix implements the correct native calling convention in the SPARC
>>>> ABI [1] in SPARCHotSpotRegisterConfig.java.
>>>>
>>>> The rest of the change is a jtreg test which exercises native calls on
>>>> AMD64 and SPARC with code installed via JVMCI. Different parameter 
>>>> types
>>>> and argument counts are tested.
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8159368
>>>> http://cr.openjdk.java.net/~sanzinger/8159368/webrev.01/
>>>>
>>>> Reference:
>>>> [1] http://sparc.org/wp-content/uploads/2014/01/SCD.2.4.1.pdf.gz
>>>>
>>>> Stefan
>>



More information about the hotspot-compiler-dev mailing list