RFR(S): 8157984 - [TESTBUG] Several compiler tests fails when are executed with -XX:TieredStopAtLevel=1

[Vladimir Ivanov]

General question: why do you fix the tests differently?


test/compiler/rangechecks/TestRangeCheckSmearing.java:

+        int maxLevel = 
Arrays.stream(CompilerUtils.getAvailableCompilationLevels()).max().getAsInt();
+        if (Platform.isServer() && maxLevel == 
CompilerWhiteBoxTest.COMP_LEVEL_FULL_OPTIMIZATION) {

Can you extract it into an utility method somewhere in the test library?


test/compiler/tiered/NonTieredLevelsTest.java:

+ * @requires vm.opt.TieredStopAtLevel!=1 & vm.opt.TieredStopAtLevel!=2 
& vm.opt.TieredStopAtLevel!=3

Why isn't it just vm.opt.TieredStopAtLevel=4?

Best regards,
Vladimir Ivanov

On 7/6/16 7:56 PM, Dmitrij Pochepko wrote:
> Hi,
>
> please review fix for 8157984 - [TESTBUG] Several compiler tests fails
> when are executed with -XX:TieredStopAtLevel=1
>
>
> 3 tests failed with TieredStopAtLevl=1 option included (these tests were
> quarantined by http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/1bf96735f3be))
>
> 1) compiler/tiered/NonTieredLevelsTest.java modified to have respective
> "requires" tag
> 2) compiler/rangechecks/TestRangeCheckSmearing.java modified to have
> correct checks inside test
> 3) separate issue for compiler/ciReplay/TestVM_no_comp_level.sh was
> created so, respective @ignore tag changed.
>
> webrev: http://cr.openjdk.java.net/~dpochepk/8157984/webrev.01/
> CR: https://bugs.openjdk.java.net/browse/JDK-8157984
>
> I've tested these locally on linux-arm64 providing various vm flags like
> TieredCompilation, TieredStopAtLevel.
>
>
> Thanks,
> Dmitrij