RFR(S): 8161068: jdk.vm.ci.hotspot.test.MethodHandleAccessProviderTest fails

[Doug Simon]

Hi Michael,

There are some minor Checkstyle violations:

dsimon at kurz ~/hs-comp/hotspot> mx checkstyle | grep HotSpotMethodHandleAccessProvider.java
/Users/dsimon/hs-comp/hotspot/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodHandleAccessProvider.java:0: File does not end with a newline.
/Users/dsimon/hs-comp/hotspot/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodHandleAccessProvider.java:30: Redundant import from the same package - jdk.vm.ci.hotspot.HotSpotResolvedPrimitiveType.

Also, Eclipse shows one unused import:

Description	Resource	Path	Location	Type
The import jdk.vm.ci.meta.JavaType is never used	HotSpotMethodHandleAccessProvider.java	/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot	line 33	Java Problem

Apart from that, the webrev looks good.

-Doug

> On 13 Jul 2016, at 10:10, Michael Haupt <michael.haupt at oracle.com> wrote:
> 
> Dear all,
> 
> please review this fix.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8161068
> Webrev: http://cr.openjdk.java.net/~mhaupt/8161068/webrev.00/
> 
> MethodHandleAccessProvider (MHAP) gets hold of an ResolvedJavaMethod instance of an internal method (LambdaForm.compileToBytecode()) and uses the result of an invocation thereof. The failure occurred because MHAP looks up said method by class and name only, without verifying the signature. The fix for 8160717 contained a refactoring of LF.cTB that changed the method's result type from MemberName to void. MHAP still relied on the result, leading to an NPE causing the test to fail.
> 
> The fix introduces signature verification.
> 
> Tests run: hs-tier0-comp via RBT.
> 
> Thanks,
> 
> Michael
> 
> -- 
> 
> 
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> Oracle Java Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany
> 
> ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> 
> Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
> Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
> 	Oracle is committed to developing practices and products that help protect the environment
>