RFR(S): 8161379: @CallerSensitive methods should be forcefully inlined to get Reflection.getCallerClass optimization

[Claes Redestad]

On 2016-07-16 02:22, Remi Forax wrote:
> Looks good,

Thanks!

> obviously s/@ForceSensitive/@ForceInline

I guess it's getting late here. :-)

/Claes

>
> Rémi
>
> ----- Mail original -----
>> De: "Claes Redestad" <claes.redestad at oracle.com>
>> À: "hotspot compiler" <hotspot-compiler-dev at openjdk.java.net>, "Aleksey Shipilev" <aleksey.shipilev at oracle.com>
>> Envoyé: Samedi 16 Juillet 2016 02:12:49
>> Objet: RFR(S): 8161379: @CallerSensitive methods should be forcefully	inlined to get Reflection.getCallerClass
>> optimization
>>
>> Hi,
>>
>> Aleksey and I would like to contribute this patch which change the
>> inlining policy to treat @CallerSensitive as it would
>> @ForceSensitive.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8161379
>> Webrev: http://cr.openjdk.java.net/~redestad/8161379/webrev.01/
>>
>> The issue is that the JNI call behind Reflection.getCallerClass() is
>> very expensive compared to the C2 intrinsic. This shows up in various
>> microbenchmarks stress-testing reflection, method handle lookup etc,
>> and can be linked to a number of intermittent regressions we see appear
>> in various benchmarks.
>>
>> See the bug for more information.
>>
>> Testing: JPRT -testset hotspot, RBT hotspot-nightly-compiler
>>
>> Thanks!
>>
>> /Claes
>>