RFR(S): 8161379: @CallerSensitive methods should be forcefully inlined to get Reflection.getCallerClass optimization

Claes Redestad claes.redestad at oracle.com
Mon Jul 18 21:26:00 UTC 2016



On 2016-07-18 19:32, Christian Thalinger wrote:
>
>> On Jul 16, 2016, at 12:22 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
>>
>>
>>
>> On 2016-07-16 04:17, Christian Thalinger wrote:
>>> Why are you not setting the _force_inline bit on @CallerSensitive?  It would be less intrusive and more global so other compilers would pick it up as well.
>>
>> We figured having ability to distinguish between reasons for why we're
>> force inlining could come in handy, but since the behavior would be the
>> same I'd be happy to simplify this if that'll make things easier for
>> other compilers.
>
> It would.  Just document somewhere (in HotSpot) that @CallerSensitive also enables @ForceInline.

The cleanest place to do this then I believe would be in the class file
parser; would that work well with the compilers you had in mind?

http://cr.openjdk.java.net/~redestad/8161379/webrev.02/

Thanks!

/Claes


More information about the hotspot-compiler-dev mailing list