RFR(XS): 8161907: adlc: Fix crash in cisc_spill_match if _rChild == NULL"

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Jul 26 07:24:21 UTC 2016


Thanks a lot Vladimir!

Best regards,
  Goetz.

> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: Dienstag, 26. Juli 2016 03:31
> To: hotspot-compiler-dev at openjdk.java.net
> Subject: Re: RFR(XS): 8161907: adlc: Fix crash in cisc_spill_match if _rChild ==
> NULL"
> 
> Done.
> 
> Vladimir
> 
> On 7/25/16 3:13 AM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > Could someone please sponsor this small fix?
> > I rebased the change and added the Reviewed-by annotation:
> > http://cr.openjdk.java.net/~goetz/wr16/8161907-adlc/webrev.01
> >
> > Best regards,
> >   Goetz.
> >
> >
> >> -----Original Message-----
> >> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> >> bounces at openjdk.java.net] On Behalf Of Lindenmaier, Goetz
> >> Sent: Mittwoch, 20. Juli 2016 22:48
> >> To: 'Vladimir Kozlov' <vladimir.kozlov at oracle.com>; hotspot-compiler-
> >> dev at openjdk.java.net
> >> Subject: RE: RFR(XS): 8161907: adlc: Fix crash in cisc_spill_match if _rChild
> ==
> >> NULL"
> >>
> >> Thanks Vladimir!
> >>
> >> Best regards,
> >>   Goetz.
> >>
> >>> -----Original Message-----
> >>> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> >>> Sent: Wednesday, July 20, 2016 5:52 PM
> >>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-
> compiler-
> >>> dev at openjdk.java.net
> >>> Subject: Re: RFR(XS): 8161907: adlc: Fix crash in cisc_spill_match if _rChild
> >> ==
> >>> NULL"
> >>>
> >>> Looks good.
> >>>
> >>> Thanks,
> >>> Vladimir
> >>>
> >>> On 7/20/16 3:39 AM, Lindenmaier, Goetz wrote:
> >>>> Hi,
> >>>>
> >>>>
> >>>>
> >>>> Please review and sponsor this tiny, rather obvious change:
> >>>>
> >>>> http://cr.openjdk.java.net/~goetz/wr16/8161907-adlc/
> >>>>
> >>>>
> >>>>
> >>>> _rChild is never checked for NULL, but it is dereferenced.
> >>>>
> >>>> We have a rule that causes a crash here.
> >>>>
> >>>>
> >>>>
> >>>> Best regards,
> >>>>
> >>>>   Goetz.
> >>>>
> >>>>
> >>>>


More information about the hotspot-compiler-dev mailing list