RFR: 8146416: java.lang.OutOfMemoryError triggers: assert(current_bci == 0) failed: bci isn't zero for do_not_unlock_if_synchronized

[Jamsheed C m]

Hi Roland,

Addressed all comments:

1) removed xmx settings

2) cleared JVMTI pending early return.

3) Removed Uncommon trap test case(as its heavily tuned, and will not 
work for most of heap settings).

revised webrev: http://cr.openjdk.java.net/~jcm/8146416/webrev.03/

Best Regards,

Jamsheed

On 6/2/2016 5:33 PM, Jamsheed C m wrote:
>
> Hi Roland,
>
> Thank you  for the review comments.
>
> On 6/2/2016 5:02 PM, Roland Westrelin wrote:
>>> revised webrev: http://cr.openjdk.java.net/~jcm/8146416/webrev.02/
>> Thanks for making the change.
>>
>> In vframeArrayElement::unpack_on_stack(), for jvmti's early return, I
>> think you want to call state->clear_earlyret_pending() otherwise the
>> early ret is still pending and that could lead to an unexpected
>> behaviour.
> i missed that one, will make the change.
>>
>> In your test cases, I would suggest bumping the heap size to avoid
>> future problems with the test case like this one:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8042557
>
> Ok
>>
>> Does DeoptReallocFailureUncommonTrap.java cover a case that's not
>> covered by test/compiler/uncommontrap/TestDeoptOOM.java? Does it fail
>> with jvmci/graal?
> i added this test case for uncommon_trap verification. let me check 
> whether this one duplicate a test in TestDeoptOOM.java.
>
> Best Regards,
> Jamsheed
>
>>
>> Roland.
>