[9] RFR (S): 8157181: Compilers accept modification of final fields outside initializer methods

[Zoltán Majó]

Hi Vladimir,


On 06/10/2016 05:09 PM, Vladimir Ivanov wrote:
>> Here is the updated webrev:
>> http://cr.openjdk.java.net/~zmajo/8157181/webrev.09/
>
> Looks good.

thank you!

>
> Last comment:
>
> src/share/vm/interpreter/rewriter.cpp:
>
> +           if (!(method->is_native() || method->is_abstract() || 
> method->is_overpass())) {
>
> Seems redundant. Native & abstract methods don't have body.
> Shouldn't happen for overpasses as well (AFAIK they don't contain 
> putstatic/putfield instructions), but it's better to analyze them 
> (just in case).

OK, I've removed that condition.

Here is the updated webrev:
http://cr.openjdk.java.net/~zmajo/8157181/webrev.10/

JPRT is in progress.

Thank you and best regards,


Zoltan

>
> Best regards,
> Vladimir Ivanov