[9] RFR (S): 8157181: Compilers accept modification of final fields outside initializer methods
Zoltán Majó
zoltan.majo at oracle.com
Wed Jun 15 12:17:58 UTC 2016
Hi Coleen,
On 06/15/2016 02:07 PM, Coleen Phillimore wrote:
>
>
>
> On 6/15/16 8:03 AM, Zoltán Majó wrote:
>> Hi Coleen,
>>
>>
>> On 06/14/2016 04:34 PM, Coleen Phillimore wrote:
>>> [...]
>>>
>>> I would vote for pre-deprecating or removing the flag. We don't
>>> generally add flags for new spec enforcement unless we anticipate a
>>> lot of customers having problems with the new rule.
>>
>> OK.
>>
>>> Just make sure the error message is really good though, so that when
>>> people hit this new rule, they'll know what to fix.
>>
>> The change I propose tries to make the error message a bit more
>> informative, please see the changes to linkResolver.cpp in the webrev:
>>
>> http://cr.openjdk.java.net/~zmajo/8157181/webrev.11/src/share/vm/interpreter/linkResolver.cpp.sdiff.html
>>
>>
>> I hope that is good enough.
>
> These messages and this change looks good
Thank you!
> (looked at cdiff because sdiffs don't look right).
Sorry, I should have sent you the cdiffs...
Best regards,
Zoltan
>
> Thanks,
> Coleen
>>
>> Thank you and best regards,
>>
>>
>> Zoltan
>>
>>>
>>> Coleen
>>>>
>>>> Best regards,
>>>> Vladimir Ivanov
>>>>
>>>> [1] https://wiki.openjdk.java.net/display/quality/Quality+Outreach
>>>
>>
>
More information about the hotspot-compiler-dev
mailing list