[9] RFR (S): 8157181: Compilers accept modification of final fields outside initializer methods

Zoltán Majó zoltan.majo at oracle.com
Wed Jun 15 12:18:45 UTC 2016


Hi Coleen,


On 06/15/2016 02:09 PM, Coleen Phillimore wrote:
>
> Okay with this one ...  Thank you for making this significant change.

thank you for the review!

Best regards,


Zoltan

> Coleen
>
>
> On 6/15/16 8:07 AM, Zoltán Majó wrote:
>> Hi David,
>>
>>
>> On 06/14/2016 11:02 PM, David Holmes wrote:
>>> [...]
>>>> I would vote for pre-deprecating or removing the flag.  We don't
>>>> generally add flags for new spec enforcement unless we anticipate a 
>>>> lot
>>>> of customers having problems with the new rule.  Just make sure the
>>>> error message is really good though, so that when people hit this new
>>>> rule, they'll know what to fix.
>>>
>>> Okay. If this is restricted to 9 then we can drop the flag and 
>>> require any "offenders" to become compliant if they plan to ship 
>>> Java 9 version bytecode.
>>
>> OK, I've removed the flag. Here is the newest webrev:
>> http://cr.openjdk.java.net/~zmajo/8157181/webrev.12/
>>
>> Thank you!
>>
>> Best regards,
>>
>>
>> Zoltan
>>
>>>
>>> David
>>> -----
>>>
>>>>
>>>> Coleen
>>>>>
>>>>> Best regards,
>>>>> Vladimir Ivanov
>>>>>
>>>>> [1] https://wiki.openjdk.java.net/display/quality/Quality+Outreach
>>>>
>>
>



More information about the hotspot-compiler-dev mailing list