RFR(XXS) : 8158754 : compilercontrol tests: RandomCommandsTest.java and RandomValidCommandsTest.java - fail in PIT

Nils Eliasson nils.eliasson at oracle.com
Thu Jun 16 11:19:08 UTC 2016


Hi,

Looks good!

Regards,
Nils

On 2016-06-15 22:03, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8158754/webrev.00/
>> 1 line changed: 1 ins; 0 del; 0 mod;
> Hi all,
>
> could you please review this tiny fix for two compiler control tests? the tests spawn a new jvm and pass CompilerDirectivesLimit flag which is diagnostic, but don’t pass -XX:+UnlockDiagnosticVMOptions. so the tests fail on product builds. the fix simply adds -XX:+UnlockDiagnosticVMOptions.
>
> tested: locally on macos using both product and fastdebug builds
> JBS: https://bugs.openjdk.java.net/browse/JDK-8158754
> webrev: http://cr.openjdk.java.net/~iignatyev/8158754/webrev.00/
>
> Thanks,
> — Igor
>
>



More information about the hotspot-compiler-dev mailing list