[9] RFR(S): 8159715: Fix for 8072422 is incorrect

Tobias Hartmann tobias.hartmann at oracle.com
Thu Jun 16 14:00:53 UTC 2016


Hi Zoltan,

thanks for the review!

Best regards,
Tobias

On 16.06.2016 15:50, Zoltán Majó wrote:
> Hi Tobias,
> 
> 
> On 06/16/2016 03:41 PM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following fix:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8159715
>> http://cr.openjdk.java.net/~thartmann/8159715/webrev.00/
> 
> thank you for catching those errors and for fixing them! The fix looks good to me.
> 
> Best regards,
> 
> 
> Zoltan
> 
>>
>> The fix for JDK-8072422 [1] removed the RangeLimitCheck flag that was set to true by default. In PhaseIdealLoop::do_range_check(), conditional_rc should now be always set to true. The LoopLimitCheck flag was also removed but the code in parse1.cpp and loopnode.cpp was not adapted correctly (see bug description).
>>
>> Tested with JPRT and RBT (running).
>>
>> Thanks,
>> Tobias
>>
>> [1] http://cr.openjdk.java.net/~zmajo/8072422/webrev.02/
> 


More information about the hotspot-compiler-dev mailing list