RFR: 8159613: [Findbugs] various warnings reported for JVMCI sources

Christian Thalinger cthalinger at twitter.com
Wed Jun 22 16:51:19 UTC 2016


> On Jun 22, 2016, at 7:25 AM, Doug Simon <doug.simon at oracle.com> wrote:
> 
>> 
>> On 22 Jun 2016, at 00:18, Christian Thalinger <cthalinger at twitter.com> wrote:
>> 
>> src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfig.java
>> 
>> I guess the problem in getHostArchitectureName is the missing default case?  I’d prefer something like this:
>> 
>> -        switch (arch) {
>> -            case "x86_64":
>>                return "amd64";
>> -            case "sparcv9":
>>                 return "sparc";
>>              default:
>>                 return arch;
>>         }
> 
> Also addressed in the v2 of the web rev.

Thanks.  Looks good.

> 
> -Doug

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160622/a86f0665/attachment.html>


More information about the hotspot-compiler-dev mailing list