Re: [9] RFR(S): 8143081: [ctw] Test CompileTheWorld.java needs to be updated for Jigsaw

[igor.ignatyev@oracle.com]

Hi Tatiana,

Thank you for adding comments. Looks good to me.

-- II

----- Reply message -----
From: "Tatiana Pivovarova" <tatiana.pivovarova at oracle.com>
To: "Igor Ignatyev" <igor.ignatyev at oracle.com>
Cc: <hotspot-compiler-dev at openjdk.java.net>
Subject: [9] RFR(S): 8143081: [ctw] Test CompileTheWorld.java needs to be updated for Jigsaw
Date: Mon, Jun 27, 2016 16:32

Hi Igor!



Thanks for your review. I added these comments.

webrev : http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.04/



Thanks,

Tatiana



On 06/24/2016 08:03 PM, Igor Ignatyev
wrote:




Hi Tatiana,

1st of all, thanks for fixing that.

I’ve one suggest: could you please add a comment why we need to call System::exit and store cout/cerr in CompileTheWorld.java? otherwise looks good to me.

Thanks,
— Igor



On Jun 23, 2016, at 8:19 PM, Tatiana Pivovarova <tatiana.pivovarova at oracle.com> wrote:

Hi guys!

Please review this patch

To run CompileTheWorld harness with new jdk9 it is need to add compatibility to read .jimage files and to remove hardcoded links to rt.jar and "sun.boot.class.path" property.

bug: https://bugs.openjdk.java.net/browse/JDK-8143081
webrev: http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.01/

Tested locally by compilation lib/modules.

Thanks,
Tatiana
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160627/fa81b9d7/attachment.html>