RFR: 8151266: HotSpotResolvedJavaFieldImpl::isStable() does not work as expected

Christian Thalinger christian.thalinger at oracle.com
Mon Mar 7 18:12:54 UTC 2016


> On Mar 7, 2016, at 8:08 AM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
> 
> 
>> On Mar 5, 2016, at 3:45 AM, Doug Simon <doug.simon at oracle.com> wrote:
>> 
>> Please review this small change that makes HotSpotResolvedJavaFieldImpl.isStable() return the right value for HotSpotResolvedJavaFieldImpl objects created from java.lang.reflect.Field objects. The problem was that HotSpotResolvedJavaField objects created from reflection objects didn’t get the VM internal modifier flags:
>> 
>> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/0adf6c8c7223/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java#l117
> 
> I think it would be better to rely on the existing logic in HotSpotResolvedObjectTypeImpl for finding and constructing the right HotSpotResolvedJavaFieldImpl.  Then we wouldn’t need a new VM entry point.

I remembered I added some code for this somewhere but couldn’t find it.  Yes, we should use that instead.

> 
> tom
> 
>> 
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8151266
>> http://cr.openjdk.java.net/~dnsimon/8151266/
>> 
>> -Doug
> 



More information about the hotspot-compiler-dev mailing list