RFR(S): 8147844: new method j.l.Runtime.onSpinWait() and the corresponding x86 hotspot instrinsic
Vitaly Davidovich
vitalyd at gmail.com
Thu Mar 10 01:39:49 UTC 2016
Minor quibble - in x86.ad:
if (VM_Version::supports_on_spin_wait() == false)
Any particular reason it's using == false form instead of
!supports_on_spin_wait?
On Wednesday, March 9, 2016, Ivan Krylov <ivan at azulsystems.com> wrote:
> Paul, Indeed, thanks. I have modified the test.
> I also made changes to reflect the fact that onSpinWait is now decided to
> be placed into j.l.Thread.
>
> Igor,
> This is a new webrev: http://cr.openjdk.java.net/~ikrylov/8147844.hs.04/
> This is the diff between previous and this patches (03 vs 04):
> http://cr.openjdk.java.net/~ikrylov/8147844.hs.04/diff.txt
>
> Thanks,
>
> Ivan
>
> On 12/02/2016 06:01, Paul Sandoz wrote:
>
>> On 12 Feb 2016, at 00:55, Ivan Krylov <ivan at azulsystems.com> wrote:
>>>
>>> Hi Igor,
>>>
>>> Thanks both for your help and your reviews.
>>> Here is a new version, tested on mac for c1 and c2:
>>>
>>> http://cr.openjdk.java.net/~ikrylov/8147844.hs.03
>>>
>>> Now that support C1 is supported should the test be updated with C1 only
>> execution?
>>
>> Paul.
>>
>
>
--
Sent from my phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160309/0ab5cf95/attachment.html>
More information about the hotspot-compiler-dev
mailing list