RFR(S): 8147844: new method j.l.Runtime.onSpinWait() and the corresponding x86 hotspot instrinsic

[Vitaly Davidovich]

On Wednesday, March 9, 2016, Ivan Krylov <ivan at azulsystems.com> wrote:

> Merely for consistency with the surrounding code. I wouldn't write it that
> way but I have to follow the practice there.
> See
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/file/7e7e50ac4faf/src/cpu/x86/vm/x86.ad
>
I looked just above the lines you added and there's a supports_cx8 check
using the ! form.  But you're right, your form appears elsewhere too in the
file.

>
>
> Thanks, Igor! I will ask someone to push the change in once the JEP
> becomes targeted.
>
> Ivan
>
> On 09/03/2016 17:39, Vitaly Davidovich wrote:
>


> Minor quibble - in x86.ad:
>
>  if (VM_Version::supports_on_spin_wait() == false)
>
> Any particular reason it's using == false form instead of
> !supports_on_spin_wait?
>
> On Wednesday, March 9, 2016, Ivan Krylov <
> <javascript:_e(%7B%7D,'cvml','ivan at azulsystems.com');>ivan at azulsystems.com
> <javascript:_e(%7B%7D,'cvml','ivan at azulsystems.com');>> wrote:
>
>> Paul, Indeed, thanks. I have modified the test.
>> I also made changes to reflect the fact that onSpinWait is now decided to
>> be placed into j.l.Thread.
>>
>> Igor,
>> This is a new webrev: http://cr.openjdk.java.net/~ikrylov/8147844.hs.04/
>> This is the diff between previous and this patches (03 vs 04):
>> http://cr.openjdk.java.net/~ikrylov/8147844.hs.04/diff.txt
>>
>> Thanks,
>>
>> Ivan
>>
>> On 12/02/2016 06:01, Paul Sandoz wrote:
>>
>>> On 12 Feb 2016, at 00:55, Ivan Krylov <ivan at azulsystems.com
>>>> <javascript:_e(%7B%7D,'cvml','ivan at azulsystems.com');>> wrote:
>>>>
>>>> Hi Igor,
>>>>
>>>> Thanks both for your help and your reviews.
>>>> Here is a new version, tested on mac for c1 and c2:
>>>>
>>>> http://cr.openjdk.java.net/~ikrylov/8147844.hs.03
>>>>
>>>> Now that support C1 is supported should the test be updated with C1
>>> only execution?
>>>
>>> Paul.
>>>
>>
>>
>
> --
> Sent from my phone
>
>
>

-- 
Sent from my phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160309/3a1dc6b9/attachment.html>