RFR: 8151470: [JVMCI] remove up-call to HotSpotJVMCICompilerConfig.selectCompiler

Doug Simon doug.simon at oracle.com
Thu Mar 10 19:19:37 UTC 2016


Ok, looks good.

> On 10 Mar 2016, at 18:03, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
> 
>> On Mar 9, 2016, at 11:55 PM, Doug Simon <doug.simon at oracle.com> wrote:
>> 
>> For more laziness, in HotSpotJVMCICompilerConfig, can you please move all the factory initialization logic into getCompilerFactory.
> 
> I can: 
> 
> http://cr.openjdk.java.net/~twisti/8151470/webrev.02/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCICompilerConfig.java.udiff.html
> 
>> 
>> 
>>> On 09 Mar 2016, at 00:05, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8151470
>>> http://cr.openjdk.java.net/~twisti/8151470/webrev.01/
>>> 
>>> The reason why it was done this way is to use a trusted system property value to select the compiler.  We can achieve the same by using VM.getSavedProperty.
>>> 
>>> This patch changes the system property name from “jvmci.compiler” to “jvmci.Compiler” as it’s using an Option now.
>>> 
>>> As discussed with Doug I also got rid of some property file parsing code that we don’t need right now.
>> 
> 



More information about the hotspot-compiler-dev mailing list