RFR: 8151266: HotSpotResolvedJavaFieldImpl::isStable() does not work as expected

[Christian Thalinger]

> On Mar 10, 2016, at 11:03 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
> https://bugs.openjdk.java.net/browse/JDK-8151664 <https://bugs.openjdk.java.net/browse/JDK-8151664>
> 
> I will just push it since it was reviewed already.

Turns out there was a missing jtreg tag:

 * @requires (os.simpleArch == "x64" | os.simpleArch == "sparcv9" | os.simpleArch == "aarch64")                                                       

> 
>> On Mar 10, 2016, at 10:58 AM, Christian Thalinger <christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>> wrote:
>> 
>> Damn.  I forgot to hg add the test:
>> 
>> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3a1f495e37b3 <http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3a1f495e37b3>
>> 
>> That’s why you should send exported changesets :-)
>> 
>>> On Mar 7, 2016, at 3:20 PM, Christian Thalinger <christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>> wrote:
>>> 
>>> 
>>>> On Mar 7, 2016, at 11:03 AM, Doug Simon <doug.simon at oracle.com <mailto:doug.simon at oracle.com>> wrote:
>>>> 
>>>> I changed the webrev to use HotSpotResolvedObjectTypeImpl instead of making a (new) VM call and also added the test provided in the bug report. 
>>> 
>>> That’s much better than I expected.  Looks good.
>>> 
>>>> 
>>>> -Doug
>>>> 
>>>>> On 07 Mar 2016, at 19:13, Christian Thalinger <christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>> wrote:
>>>>> 
>>>>> 
>>>>>> On Mar 5, 2016, at 1:45 AM, Doug Simon <doug.simon at oracle.com <mailto:doug.simon at oracle.com>> wrote:
>>>>>> 
>>>>>> Please review this small change that makes HotSpotResolvedJavaFieldImpl.isStable() return the right value for HotSpotResolvedJavaFieldImpl objects created from java.lang.reflect.Field objects. The problem was that HotSpotResolvedJavaField objects created from reflection objects didn’t get the VM internal modifier flags:
>>>>>> 
>>>>>> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/0adf6c8c7223/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java#l117 <http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/0adf6c8c7223/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMetaAccessProvider.java#l117>
>>>>>> 
>>>>>> 
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8151266 <https://bugs.openjdk.java.net/browse/JDK-8151266>
>>>>> 
>>>>> There is a test attached to the bug.  We should add it.
>>>>> 
>>>>>> http://cr.openjdk.java.net/~dnsimon/8151266/ <http://cr.openjdk.java.net/~dnsimon/8151266/>
>>>>>> 
>>>>>> -Doug
>>>>> 
>>>> 
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160310/5e06a87e/attachment-0001.html>