[9] RFR 8150850: [JVMCI] NPE when executing HotSpotConstantReflectionProvider.readStableFieldValue

Christian Thalinger christian.thalinger at oracle.com
Mon Mar 14 20:24:30 UTC 2016


Looks good.

> On Mar 14, 2016, at 2:02 AM, Konstantin Shefov <konstantin.shefov at oracle.com> wrote:
> 
> Hello
> 
> Please review a bug fix in JVMCI jdk.vm.ci.hotspot.HotSpotConstantReflectionProvider::readStableFieldValue method. 
> 
> When one executes HotSpotConstantReflectionProvider::readStableFieldValue method for an instance field and JavaConstant.NULL_POINTER as a receiver, it throws an NPE. However, the javadoc says it should return null. 
> 
> E.g. when we execute method HotSpotConstantReflectionProvider::readFieldValue for an instance field and JavaConstant.NULL_POINTER as a receiver, we get null as expected.
> 
> Additional check should be added for null as the first argument.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8150850 <https://bugs.openjdk.java.net/browse/JDK-8150850>
> Webrev: http://cr.openjdk.java.net/~kshefov/8150850/webrev.00 <http://cr.openjdk.java.net/~kshefov/8150850/webrev.00>
> 
> Thanks
> -Konstantin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160314/66195e7d/attachment.html>


More information about the hotspot-compiler-dev mailing list