[9] RFR JDK-8152344: JVMCI test task: Unit tests for ConstantReflectionProvider

[Konstantin Shefov]

Hi, Christian

Thanks for reviewing.

Here is the new patch http://cr.openjdk.java.net/~kshefov/8152344/webrev.01/

I moved tests to the folder 
hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test and tho the package 
jdk.vm.ci.hotspot.test. Also I have done some code re-formatting.

-Konstantin

On 03/22/2016 12:20 AM, Christian Thalinger wrote:
> Sorry but I have to bring this up again… there is so much 
> line-breaking going on it’s ridiculous.  Especially in:
>
> http://cr.openjdk.java.net/~kshefov/8152344/webrev.00/test/compiler/jvmci/constantReflectionProviderTest/BoxPrimitiveDataProvider.java.html 
> <http://cr.openjdk.java.net/%7Ekshefov/8152344/webrev.00/test/compiler/jvmci/constantReflectionProviderTest/BoxPrimitiveDataProvider.java.html>
>
> Or this:
>   118         Assert.assertEquals(CONSTANT_REFLECTION_PROVIDER.readStableFieldValue(field,
>   119                                                                               receiver,
>   120                                                                               isDefStab),
>   121                 expected, "Unexpected result:");
>
> Here is a suggestion.  Move your tests into the package 
> jdk.vm.ci.hotspot.test under:
>
> hotspot/test/compiler/jvmci/jdk.vm.ci.hotspot.test
>
> Look at jdk.vm.ci.runtime.test as an example.  Then we 
> add jdk.vm.ci.hotspot.test to the mx configuration file and let the 
> predefined formatting rules take care of it.
>
> This would be my preferred way because then the tests are 
> automatically imported into IDEs as well.  Actually all JVMCI tests 
> should do it this way.
>
>> On Mar 21, 2016, at 11:07 AM, Konstantin Shefov 
>> <konstantin.shefov at oracle.com> wrote:
>>
>> Hello
>>
>> Please review some new unit tests for methods of JVMCI 
>> jdk.vm.ci.hotspot.HotSpotConstantReflectionProvider class.
>>
>> The tests cover most public methods of the class named above.
>>
>> Here 
>> "test/compiler/jvmci/constantReflectionProviderTest/HotSpotConstantReflectionProviderTest.java" 
>> is the JTREG-testng file, all other classes are testng data 
>> providers, except TestHelper.java and DummyClass.java that store all 
>> necessary variables.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8152344
>> Webrev: http://cr.openjdk.java.net/~kshefov/8152344/webrev.00/
>>
>> Thanks
>> -Konstantin
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160322/efa1b187/attachment.html>