RFR(S): 8149488: Incorrect declaration of bitsInByte in regmask.cpp

[Dean Long]

When do we access elements 256 .. 511?  Wouldn't that mean we have 9-bit 
bytes?

dl

On 3/30/2016 12:19 PM, Rahul Raghavan wrote:
> Hi,
>
> With respect to below email thread, request help to review revised webrev.01 for 8149488.
>
> <bug>: https://bugs.openjdk.java.net/browse/JDK-8149488
> <webrev.01>: http://cr.openjdk.java.net/~rraghavan/8149488/webrev.01/
>
> Now as required, fixed the issue by extending bitsInByte array size from 256 to 512.
> Defined and used BITS_IN_BYTE_ARRAY_SIZE for the array size as 512.
> Confirmed no issues with 'JPRT -testset hotspot' run.
>
> Thanks,
> Rahul
>
>> -----Original Message-----
>> From: Berg, Michael C [mailto:michael.c.berg at intel.com] > Sent: Thursday, February 11, 2016 11:32 PM > To: hotspot-compiler-dev at openjdk.java.net
>>
>> Should we not extend:
>>
>> This does not match the actual definition in share/vm/libadt/vectset.cpp:
>>   uint8_t bitsInByte[256] = { // ...
>>
>> to 512
>>
>> -----Original Message-----
>> From: Berg, Michael C > Sent: Thursday, February 11, 2016 9:57 AM > To: 'Vladimir Ivanov'
>>
>> So how do we intend to map a VecZ register without 512 bits?
>>
>> -Michael
>>
>> -----Original Message-----
>> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Ivanov
>> Sent: Thursday, February 11, 2016 4:54 AM > To: Rahul Raghavan; hotspot-compiler-dev at openjdk.java.net
>>
>> Rahul,
>>
>> Can we define a constant instead and use it in both places?
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 2/11/16 10:42 AM, Rahul Raghavan wrote:
>>> Hi,
>>>
>>> Please review the patch for JDK- 8149488.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8149488
>>> Webrev: http://cr.openjdk.java.net/~thartmann/8149488/webrev.00/
>>>
>>> Corrected the bitsInByte array size in declaration.
>>>
>>> Thanks,
>>> Rahul
>>>