RFR(S): 8150921: Update Unsafe getters/setters to use double-register variants

[Paul Sandoz]

> On 3 May 2016, at 11:43, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
> New webrev(s) here:
> 
> jdk: http://cr.openjdk.java.net/~mikael/webrevs/8150921/webrev.02/jdk/webrev/
> hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8150921/webrev.02/hotspot/webrev/
> 

 266     /** @see #getInt(Object, long) */
 267     @ForceInline
 268     public long getAddress(Object o, long offset) {
 269         if (ADDRESS_SIZE == 4) {
 270             return Integer.toUnsignedLong(getInt(o, offset));
 271         } else {
 272             return getLong(o, offset);
 273         }
 274     }
 275
 276     /** @see #putInt(Object, long, int) */
 277     @ForceInline
 278     public void putAddress(Object o, long offset, long x) {
 279         if (ADDRESS_SIZE == 4) {
 280             putInt(o, offset, (int)x);
 281         } else {
 282             putLong(o, offset, x);
 283         }
 284     }


Why not just copy the documentation from the single register variant, or perhaps just switch it over? so the single @see’s the double register variant.

Paul.


> Incremental from webrev.01:
> 
> jdk: N/A (no changes)
> hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8150921/webrev.02.incr/hotspot/webrev/
> 
> Cheers,
> Mikael
> 
>> 
>> Thanks,
>> -Aleksey
>> 
>> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160503/1bb36263/signature-0001.asc>