RFR(S): 8154943: AArch64: redundant address computation instructions with vectorization
Roland Westrelin
rwestrel at redhat.com
Fri May 6 09:28:13 UTC 2016
Thanks for pushing this, Vladimir!
Roland.
On 05/04/2016 09:36 AM, Roland Westrelin wrote:
> Thanks for the review, Vladimir. Can someone sponsor this? Here is a
> changeset ready to be imported:
>
> http://cr.openjdk.java.net/~roland/8154943/8154943.patch
>
> Roland.
>
> On 04/29/2016 06:06 PM, Vladimir Kozlov wrote:
>> Yes, this looks good.
>>
>> Thanks,
>> Vladimir
>>
>> On 4/29/16 8:49 AM, Roland Westrelin wrote:
>>>> node.cpp change is good.
>>>>
>>>> compile.cpp I understand when you replace "similar" (same in(1)) node
>>>> with it but it is not clear that you also processing users (whole
>>>> following chain) to remove similar nodes. Add comment.
>>>> I think the check "!(k->Opcode() == Op_ConvI2L || ... " (and use
>>>> 'continue' instead of 'break') should be done when you push a node on
>>>> the list wq.push(u).
>>>
>>> Thanks for the review, Vladimir. What about this?
>>>
>>> http://cr.openjdk.java.net/~roland/8154943/webrev.01/
>>>
>>> Roland.
>>>
More information about the hotspot-compiler-dev
mailing list