RFR 8152343: JVMCI test tasks: Unit tests for MetaAccessProvider

[dmitrij pochepko]

>
>> On May 6, 2016, at 4:25 AM, Dmitrij Pochepko 
>> <dmitrij.pochepko at oracle.com <mailto:dmitrij.pochepko at oracle.com>> wrote:
>>
>> Hi,
>>
>> please review patch for 8152343: JVMCI test tasks: Unit tests for 
>> MetaAccessProvider
>>
>> A new tests were added for jdk.vm.ci.meta.MetaAccessProvider 
>> implementation. An existing TestMetaAccessProvider.java was used to 
>> add new tests.
>>
>> webrev: http://cr.openjdk.java.net/~dpochepk/8152343/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Edpochepk/8152343/webrev.01/>
> + private static final int[] VALID_ENCODED_VALUES = new int[]{-180, 
> -436, -10932, -2147483572};
> What are these values?  Maybe it would make more sense to have them in 
> hex-form?
These values are encoded values for deoptReason=Aliasing, 
deoptAction=InvalidateRecompile and debugId={0, 1, 42, 8388607}
so, we have 0, 1, <some non-border value>, 0x7FFFFF which is a maximum 
debugId value here(all 23 bits set)

I've created another webrev with hex values and respective comment added.

http://cr.openjdk.java.net/~dpochepk/8152343/webrev.02

Thanks,
Dmitrij
>
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8152343
>>
>> I've tested it on linux_x64.
>>
>> Thanks,
>> Dmitrij
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160508/2687b574/attachment.html>