RFR: 8153655: Make intrinsics flags diagnostic and update intrinsics tests to enable diagnostic options.

[Rahul Raghavan]

Thank you Vladimir.

> -----Original Message-----
> From: Vladimir Kozlov > Sent: Friday, May 06, 2016 1:19 AM
> 
> Looks good.
> 
> thanks,
> Vladimir
> 
> On 5/5/16 4:31 AM, Rahul Raghavan wrote:
> > Hi,
> >
> > Thank you Vladimir for review comments.
> > Yes, now updated the changes.
> >
> > Please review following revised webrev -
> > http://cr.openjdk.java.net/~rraghavan/8153655/webrev.01/
> > (Modified 'test/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedX86CPU.java')
> >
> > No issues found with testing done using product builds with proposed changes
> > (hotspot/test/compiler/cpuflags/*, hotspot/test/compiler/intrinsics/* etc.)
> > Complete pre-integration testing using product builds is in progress for this 'webrev.01'.
> > (No issues with pre-integration testing done earlier for 'webrev.00'.)
> >
> > Thanks,
> > Rahul
> >
> >> -----Original Message-----
> >> From: Vladimir Kozlov > Sent: Friday, April 29, 2016 5:33 AM
> >>
> >> Hi Rahul,
> >>
> >> Changes looks good but you need to update changes for SHA tests because I changed them for JDK-8154495:
> >>
> >> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/6a17c49de974
> >>
> >> Thanks,
> >> Vladimir
> >>
> >> On 4/27/16 2:45 AM, Rahul Raghavan wrote:
> >>> Hi,
> >>>
> >>> Please review the following patch for JDK-8153655.
> >>>
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153655
> >>> Webrev: http://cr.openjdk.java.net/~rraghavan/8153655/webrev.00/
> >>>
> >>>
> >>> Notes:
> >>>
> >>> 1. This 8153655/webrev.00 re-includes earlier backed out, same JDK-8145348 changes
> >>>          (https://bugs.openjdk.java.net/browse/JDK-8145348 - Make intrinsics flags diagnostic)
> >>> and also additional fixes in failing intrinsic tests.
> >>>
> >>>
> >>> 2. Checked all the usages of changed intrinsic flags in tests and
> >>> found JDK-8153655 type test failure issue (after initial JDK-8145348 fix) is present only for following tests -
> >>>      a. UseAESIntrinsics test (compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java)
> >>>      b. UseSHA* tests (at compiler/intrinsics/sha/cli/)
> >>>
> >>>
> >>> 3. Summary of 8153655/webrev.00 changes.
> >>>
> >>> - Includes earlier backed out, same JDK-8145348 changes:
> >>>          src/share/vm/c1/c1_globals.hpp
> >>>          src/share/vm/opto/c2_globals.hpp
> >>>          src/share/vm/runtime/globals.hpp
> >>>          test/compiler/intrinsics/muladd/TestMulAdd.java
> >>>          test/compiler/runtime/6859338/Test6859338.java
> >>>
> >>> - 'test/compiler/cpuflags/AESIntrinsicsBase.java'
> >>>         Options were passed in wrong order.
> >>>         Changes done so that 'UnlockDiagnosticVMOptions' option precedes the diagnostic flags.
> >>>
> >>> - 'test/compiler/intrinsics/sha/cli/*' - (UseSHA* tests)
> >>>        'UnlockDiagnosticVMOptions' option was not getting passed.
> >>>        Added support to precede intrinsic flag usages with explicit 'UnlockDiagnosticVMOptions'.
> >>>
> >>>
> >>> 4. No issues found with testing done using product builds with proposed changes
> >>> (hotspot/test/compiler/cpuflags/*, hotspot/test/compiler/intrinsics/*,
> hotspot/test/compiler/runtime/6859338/Test6859338.java)
> >>> Complete pre-integration testing using product builds is in progress.
> >>>
> >>>
> >>> Thanks,
> >>> Rahul
> >>>