RFR: 8156034: [JVMCI] Notify the jvmci compiler on completion of a bootstrap

[Christian Thalinger]

> On May 10, 2016, at 6:12 AM, Josef Eisl <josef.eisl at jku.at> wrote:
> 
> Hi!
> 
> May I get a review for this JVMCI change.
> 
> webrev: http://cr.openjdk.java.net/~jeisl/8156034/webrev/
src/share/vm/jvmci/jvmciCompiler.cpp

+  _bootstrap_compilation_request_seen =  false;
Remove the extra space after =

src/share/vm/jvmci/jvmciCompiler.hpp

+   * True if we have seen the a bootstrap compilation request.
Typo “the a”.

src/share/vm/jvmci/jvmciRuntime.cpp

+void JVMCIRuntime::bootstrapFinished() {
Rename the method to bootstrap_finished.  Also, this method should use TRAPS and propagate the exception.  In JNI_CreateJavaVM_inner use something like this to report exceptions:

      if (HAS_PENDING_EXCEPTION) {
        HandleMark hm;
        vm_exit_during_initialization(Handle(THREAD, PENDING_EXCEPTION));
      }
+  if (_HotSpotJVMCIRuntime_instance != NULL) {
Can this ever be not true at this point?


test/compiler/jvmci/events/JvmciNotifyBootstrapFinishedEventTest.java
  27  * @requires (os.simpleArch == "x64" | os.simpleArch == "sparcv9" | os.simpleArch == "aarch64")
  28  * @requires (os.simpleArch == "x64" | os.simpleArch == "sparcv9" | os.simpleArch == "aarch64")
Remove duplicate line.

> bug: https://bugs.openjdk.java.net/browse/JDK-8156034
> 
> It passes all jvmci tests.
> 
> Note that this changes depends on
> https://bugs.openjdk.java.net/browse/JDK-8155023
> 
> Thanks in advance,
> Josef
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160510/ed50716e/attachment.html>