RFR: 8152341 - JVMCI test task: Unit tests for MemoryAccessProvider

[Dmitrij Pochepko]

I've merged broken lines and rerun mx eclipseformat with mx checkstyle.

Please take a look at 
http://cr.openjdk.java.net/~dpochepk/8152341/webrev.05/

Thanks,
Dmitrij
>
> Please take a look at v04 with this issue fixed.
>
> http://cr.openjdk.java.net/~dpochepk/8152341/webrev.04
>
> Thanks,
> Dmitrij
>>
>>> On May 10, 2016, at 6:51 AM, Dmitrij Pochepko 
>>> <dmitrij.pochepko at oracle.com <mailto:dmitrij.pochepko at oracle.com>> 
>>> wrote:
>>>
>>> Hi,
>>>
>>> I've prepared v03 with no checkstyle errors by creating larger lines.
>>>
>>> http://cr.openjdk.java.net/~dpochepk/8152341/webrev.03/ 
>>> <http://cr.openjdk.java.net/%7Edpochepk/8152341/webrev.03/>
>>    90     @Test(dataProvider = "negative", dataProviderClass = MemoryAccessProviderData.class, expectedExceptions = {IllegalArgumentException.class })
>>    91     public void testNegativeReadPrimitiveConstant(JavaKind kind, Constant base) {
>>    92         PROVIDER.readPrimitiveConstant(kind, base, 0L,
>>    93                 kind == null ? 0 : kind.getBitCount());
>>    94     }
>> The formatting still looks odd.  I’ve noticed that sometimes Eclipse 
>> doesn’t merge lines when it actually could.  Doug, have you noticed 
>> that too?
>>
>>>
>>> Thanks,
>>> Dmitrij
>>>>> On 10 May 2016, at 16:33, Dmitrij Pochepko 
>>>>> <dmitrij.pochepko at oracle.com <mailto:dmitrij.pochepko at oracle.com>> 
>>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Yes. I was using netbeans. I've applied eclipse formatter, then 
>>>>> run mx checkstyle and fixed all warnings except " '.' is preceded 
>>>>> with whitespace". Fixing this warning will make huge lines.
>>>> You can disable the formatter with:
>>>>
>>>> // @formatter:off
>>>>
>>>> code that won’t be formatted
>>>>
>>>> // @formatter:on
>>>>
>>>> However, the lines don’t look so long to me - maybe you need to get 
>>>> a larger monitor ;-)
>>>>
>>>> -Doug
>>>>
>>>>> Thanks,
>>>>> Dmitrij
>>>>>>> On May 6, 2016, at 4:38 AM, Dmitrij Pochepko 
>>>>>>> <dmitrij.pochepko at oracle.com> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> please review patch for 8152341 - JVMCI test task: Unit tests 
>>>>>>> for MemoryAccessProvider
>>>>>>>
>>>>>>> A new tests were added for MemoryAccessProvider implementation. 
>>>>>>> This patch contains tests for all MemoryAccessProvider methods 
>>>>>>> (mostly a positive and few negative tests per method). A testng 
>>>>>>> framework is used.
>>>>>>>
>>>>>>> webrev: http://cr.openjdk.java.net/~dpochepk/8152341/webrev.01/ 
>>>>>>> <http://cr.openjdk.java.net/%7Edpochepk/8152341/webrev.01/>
>>>>>> These two files don’t look like they have been formatted 
>>>>>> properly.  Did you use an IDE to edit these?
>>>>>>
>>>>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8152341
>>>>>>>
>>>>>>> I've tested it on linux_x64
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Dmitrij
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20160511/3cc74e85/attachment-0001.html>