RFR: 8152342 - JVMCI test task: Unit tests for MethodHandleAccessProvider
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed May 11 19:21:54 UTC 2016
Good. Missing @bug
Thanks,
Vladimir
On 5/10/16 10:34 AM, Dmitrij Pochepko wrote:
> Hi,
>
> please check v02: http://cr.openjdk.java.net/~dpochepk/8152342/webrev.02/
>
> I've applied eclipse formatter and fixed checkstyle warnings.
>
> Thanks,
> Dmitrij
>
>>> On May 6, 2016, at 4:44 AM, Dmitrij Pochepko
>>> <dmitrij.pochepko at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> please review patch for 8152342 - JVMCI test task: Unit tests for
>>> MethodHandleAccessProvider
>>>
>>> A new tests were added for MethodHandleAccessProvider implementation.
>>> This patch contains tests for all MethodHandleAccessProvider methods
>>> (mostly a positive and few negative tests per method). A testng
>>> framework is used. MethodHandleAccessProviderData is used as testng
>>> data provider for MethodHandleAccessProviderTest.
>>>
>>> webrev: http://cr.openjdk.java.net/~dpochepk/8152342/webrev.01
>> Same formatting question.
>>
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8152342
>>>
>>> I've tested it on linux_x64
>>>
>>> Thanks,
>>> Dmitrij
>>>
>>>
>
More information about the hotspot-compiler-dev
mailing list