RFR: 8141149 - [jittester] create Visitor for generating bytecode

Igor Ignatyev igor.ignatyev at oracle.com
Thu May 12 08:03:21 UTC 2016


Great job indeed! reviewed.

Thanks,
— Igor
> On May 12, 2016, at 6:26 AM, Igor Veresov <igor.veresov at oracle.com> wrote:
> 
> Great job! Looks good to me.
> 
> igor
> 
>> On May 11, 2016, at 6:41 PM, dmitrij pochepko <dmitrij.pochepko at oracle.com> wrote:
>> 
>> Hi,
>> 
>> please review cumulative fix for 8141149 - ‘[jittester] create Visitor for generating bytecode’ and 8149463 - ‘[jittester] rarely generates tests with compile error’.
>> 
>> 8141149 is a massive update introducing new functionality - direct bytecode generation. A special ByteCodeVisitor was created and a number of common classes were changed to support ByteCodeVisitor. These changes also affects java code generation part because of changes in common part. the changeset also includes a bug fix for 8149463 which caused incorrectly generated IR.
>> 
>> webrev: http://cr.openjdk.java.net/~dpochepk/8141149/webrev.01/
>> CRs: https://bugs.openjdk.java.net/browse/JDK-8141149
>> https://bugs.openjdk.java.net/browse/JDK-8149463
>> 
>> Thanks,
>> Dmitrij
>> 
>> 
>> 
> 



More information about the hotspot-compiler-dev mailing list