RFR(M): 8141635: Implement new Unsafe intrinsics on POWER
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri May 13 18:30:54 UTC 2016
Looks good.
It changed shared code so FC rules apply. But changes are under
support_IRIW_for_not_multiple_copy_atomic_cpu flag which is true only
for PPC. We can say it is platform specific.
Should be pushed through JPRT since there are shared changes.
Thanks,
Vladimir
On 5/13/16 9:01 AM, Volker Simonis wrote:
> Hi Aleksey,
>
> thanks for testing! I think your changes are fine.
>
> Following the other discussion on the mailing list, I think hs-comp
> should be open for checkins and looking at the repo I see that there
> have been quite some pushes in the days. But it is of course better to
> double-check this.
>
> Thanks for sponsoring,
> Volker
>
>
> On Fri, May 13, 2016 at 2:24 PM, Aleksey Shipilev
> <aleksey.shipilev at oracle.com> wrote:
>> Hi,
>>
>> On 05/04/2016 08:57 PM, Volker Simonis wrote:
>>> Aleksey, could you please run the change through JPRT and sponsor it
>>> once your happy with it?
>>
>> I ran this version through our testing, and it seems clean:
>> http://cr.openjdk.java.net/~shade/8141635/webrev.01/
>>
>> My changes are mostly minimizing the impact on shared code parts. Not
>> sure if we can push this to hs-comp, having the pending FC. Let us
>> figure this out separately. I'll push as soon as it's clear what to do.
>>
>> Thanks,
>> -Aleksey
>>
>>
More information about the hotspot-compiler-dev
mailing list