RFR: 8156835: [JVMCI] clean up and minimize JVMCI
Igor Veresov
igor.veresov at oracle.com
Wed May 18 22:05:24 UTC 2016
Looks ok.
igor
> On May 18, 2016, at 2:35 PM, Doug Simon <doug.simon at oracle.com> wrote:
>
> I made one last minor change to improve the javadoc for MemoryAccessProvider.readObjectConstant:
>
> @@ -59,7 +59,9 @@
> *
> * @param base the base address from which the value is read
> * @param displacement the displacement within the object in bytes
> - * @return the read value encapsulated in a {@link Constant} object
> + * @return the read value encapsulated in a {@link Constant} object or {@code null} if the
> + * address computed from {@code base} and {@code displacement} does not denote a
> + * location holding an {@code Object} value
> */
> JavaConstant readObjectConstant(Constant base, long displacement);
> }
>
> If that looks ok, then Tom will integrate the webrev.
>
> -Doug
>
>> On 17 May 2016, at 19:59, Igor Veresov <igor.veresov at oracle.com> wrote:
>>
>> Looks good.
>>
>> igor
>>
>>> On May 17, 2016, at 5:53 AM, Doug Simon <doug.simon at oracle.com> wrote:
>>>
>>> I had forgotten to re-apply the removal of UnsafeUtil from https://bugs.openjdk.java.net/browse/JDK-8156759 to 8156835. I’ve applied it now and updated the webrev.
>>>
>>>> On 13 May 2016, at 21:54, Doug Simon <doug.simon at oracle.com> wrote:
>>>>
>>>>
>>>>> On 13 May 2016, at 18:21, Igor Veresov <igor.veresov at oracle.com> wrote:
>>>>>
>>>>> Looks ok
>>>>
>>>> Thanks for the review.
>>>>
>>>> -Doug
>>>>
>>>>>> On May 13, 2016, at 4:40 AM, Doug Simon <doug.simon at oracle.com> wrote:
>>>>>>
>>>>>> Please review this RFE that makes minor changes to clean up and minimize JVMCI.
>>>>>>
>>>>>> All jtreg tests pass as do all Graal tests.
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8156835
>>>>>> http://cr.openjdk.java.net/~dnsimon/8156835
>>>>>>
>>>>>> -Doug
>>>>>
>>>>
>>>
>>
>
More information about the hotspot-compiler-dev
mailing list