8157683 Thread.onSpinWait intrinsification doesn't have sufficient test coverage

[Vladimir Kozlov]

Looks good but you don't need /othervm when there no any flags:

 > @run main/othervm TestOnSpinWaitEnableDisable

Thanks,
Vladimir

On 5/24/16 1:22 PM, Paul Sandoz wrote:
> Hi
>
> Please review a simple basic test ensuring no errors/exceptions occur when invoking Thread.onSpinWait when the intrinsic is enabled (on appropriate platforms) and explicitly disabled.
>
> JPRT with the hotspot test set passes on all platforms.
>
> Paul.
>
> diff -r 6054182379a7 test/compiler/onSpinWait/TestOnSpinWaitEnableDisable.java
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/test/compiler/onSpinWait/TestOnSpinWaitEnableDisable.java	Tue May 24 18:21:39 2016 +0200
> @@ -0,0 +1,39 @@
> +/*
> + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
> + * Copyright 2016 Azul Systems, Inc.  All Rights Reserved.
> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 only, as
> + * published by the Free Software Foundation.
> + *
> + * This code is distributed in the hope that it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
> + * version 2 for more details (a copy is included in the LICENSE file that
> + * accompanied this code).
> + *
> + * You should have received a copy of the GNU General Public License version
> + * 2 along with this work; if not, write to the Free Software Foundation,
> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
> + *
> + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
> + * or visit www.oracle.com if you need additional information or have any
> + * questions.
> + */
> +
> +/**
> + * @test TestOnSpinWaitEnableDisable
> + * @summary Test to ensure basic functioning of java.lang.Thread.onSpinWait
> + * @bug 8157683
> + * @run main/othervm TestOnSpinWaitEnableDisable
> + * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_onSpinWait TestOnSpinWaitEnableDisable
> + */
> +
> +public class TestOnSpinWaitEnableDisable {
> +    public static void main(String[] args) {
> +        for (int i = 0; i < 50_000; i++) {
> +            java.lang.Thread.onSpinWait();
> +        }
> +    }
> +}
>