RFR(XXS) : 8153994 : Compiler tests should be correctly marked with @module
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue May 31 02:07:14 UTC 2016
Looks good.
thanks,
Vladimir
On 5/30/16 2:49 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev/8153994/webrev.00/
>> 1 line changed: 1 ins; 0 del; 0 mod;
>
> Hi all,
>
> could you please review this tiny fix which adds missed dependency declaration to test/compiler/codecache/jmx/PoolsIndependenceTest.java?
> the test uses classes from java.management module, but didn’t have it declared via @modules. this causes false positive results in case this module is unavailable.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8153994
> webrev: http://cr.openjdk.java.net/~iignatyev/8153994/webrev.00/
> testing: checked that the test isn’t run if '-limitmods java.compact2’ is specified, and passed otherwise.
>
> Thanks,
> — Igor
>
More information about the hotspot-compiler-dev
mailing list