[sponsor?] RE: RFR(M): 8166837: [TESTBUG] Fix tests on Linux/s390x

[Lindenmaier, Goetz]

Hi,

I think this is reviewed now.  Could someone please sponsor?
Or should I push the two non-hotspot parts myself?

Final webrevs, rebased, Copyrights fixed, Reviewed-by annotated:
http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/base-wr.02/
http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/hots-wr.02/
http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/jdk-wr.02/

Best regards,
  Goetz.


> -----Original Message-----
> From: Volker Simonis [mailto:volker.simonis at gmail.com]
> Sent: Montag, 7. November 2016 11:33
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Cc: hotspot-compiler-dev at openjdk.java.net
> Subject: Re: RFR(M): 8166837: [TESTBUG] Fix tests on Linux/s390x
> 
> Hi Goetz,
> 
> the change looks good besides the usual nitpicking:
> 
> Please update copyright year in:
> - IntrinsicPredicates.java
> - SHAOptionsBase.java
> - test_env.sh
> 
> No need for new webrev though :)
> 
> Just out of interest, why don't we need to check for ppc in:
> 
> - getWarningForUnsupportedCPU() from SHAOptionsBase.java
> - IntrinsicPredicates.java
> - GenericTestCaseForOtherCPU.java
> 
> Thanks,
> Volker
> 
> 
> On Mon, Oct 31, 2016 at 12:52 PM, Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com> wrote:
> > Hi,
> >
> >
> >
> > This change adapts the jtreg tests to work on S390.  Only compiler
> >
> > tests had to be fixed.
> >
> > Please review this change. I please need a sponsor.
> >
> > http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/hots-wr.01/
> >
> > http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/base-wr.01/
> >
> >
> > Base repository:
> > ---------------------
> > Add isS390x() to platform.java. Sort checks alphabetically.
> > Add s390x to shouldSAAttach.
> >
> > Hotspot repository:
> > -------------------------
> > compiler/ciReplay/SABase.java
> > SA writes "Command not valid until the attached to a VM" to
> test_replay.txt.
> > Disable test if SA not supported.
> >
> > compiler/intrinsics/sha/cli/...
> > Add checks for corresponding cpu feature.
> >
> > Adapt test_env.sh and TestMutuallyExclusivePlatformPredicates.java
> >
> >
> >
> > Best regards,
> >
> >   Goetz.
> >
> >