RFR: 8169317: [s390] Various minor bug fixes and adaptions.

[Lindenmaier, Goetz]

Shahid, Martin,

thanks for your thumbs up for this!

Best regards,
 Goetz.

> -----Original Message-----
> From: Shahid Shaikh [mailto:shahid at us.ibm.com]
> Sent: Freitag, 11. November 2016 11:44
> To: Doerr, Martin <martin.doerr at sap.com>
> Cc: Amod Borkar <aborkar at us.ibm.com>; Cindy Lee
> <cinderel at ca.ibm.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; hotspot-compiler-dev at openjdk.java.net
> Subject: RE: RFR: 8169317: [s390] Various minor bug fixes and adaptions.
> 
> Hi Goetz,
> 
> Our build results are out and glad to tell that the build is successful for single-
> processor z system. We tried the build on RHEL7.2 and SLES12SP1
> distributions.
> 
> For Ubuntu 16.04 the build is still failing. We tried the build on multi-
> processor intel machine as well and got the same build failure. So might be
> issue with Ubuntu distribution?
> 
> Regards,
> Shahid
> 
> "Doerr, Martin" ---11/11/2016 03:53:34 PM---Hi Götz, thanks for adding my
> patch. The webrev looks good.
> 
> From: "Doerr, Martin" <martin.doerr at sap.com>
> To: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>, Shahid
> Shaikh/Austin/Contr/IBM at IBMUS
> Cc: Cindy Lee <cinderel at ca.ibm.com>, "hotspot-compiler-
> dev at openjdk.java.net" <hotspot-compiler-dev at openjdk.java.net>, Amod
> Borkar/Austin/Contr/IBM at IBMUS
> Date: 11/11/2016 03:53 PM
> Subject: RE: RFR: 8169317: [s390] Various minor bug fixes and adaptions.
> 
> ________________________________
> 
> 
> 
> 
> Hi Götz,
> 
> thanks for adding my patch. The webrev looks good.
> 
> Best regards,
> Martin
> 
> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Lindenmaier, Goetz
> Sent: Donnerstag, 10. November 2016 16:29
> To: Shahid Shaikh <shahid at us.ibm.com>
> Cc: Cindy Lee <cinderel at ca.ibm.com>; hotspot-compiler-
> dev at openjdk.java.net; Amod Borkar <aborkar at us.ibm.com>
> Subject: RE: RFR: 8169317: [s390] Various minor bug fixes and adaptions.
> 
> Hi Shahid,
> 
> thanks for the update, good to know you are already testing it!
> I won't continue on this before tomorrow anyways, as I need reviews etc.
> 
> Best regards,
>  Goetz.
> 
> 
> > -----Original Message-----
> > From: Shahid Shaikh [mailto:shahid at us.ibm.com]
> > Sent: Donnerstag, 10. November 2016 16:22
> > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > Cc: Amod Borkar <aborkar at us.ibm.com>; Cindy Lee
> <cinderel at ca.ibm.com>;
> > hotspot-compiler-dev at openjdk.java.net
> > Subject: RE: RFR: 8169317: [s390] Various minor bug fixes and adaptions.
> >
> > Hi Goetz,
> >
> > The build is still going on. I guess it will take few hours more. We
> > will update you soon after the build completes.
> >
> > Regards,
> > Shahid
> >
> > "Lindenmaier, Goetz" ---11/10/2016 08:41:37 PM---Hi, I updated the
> > webrev with a fix by Martin Doerr, that fixes
> >
> > From: "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
> > To: "hotspot-compiler-dev at openjdk.java.net" <hotspot-compiler-
> > dev at openjdk.java.net>
> > Cc: Cindy Lee <cinderel at ca.ibm.com>, Amod
> > Borkar/Austin/Contr/IBM at IBMUS, Shahid
> Shaikh/Austin/Contr/IBM at IBMUS
> > Date: 11/10/2016 08:41 PM
> > Subject: RE: RFR: 8169317: [s390] Various minor bug fixes and adaptions.
> >
> > ________________________________
> >
> >
> >
> >
> > Hi,
> >
> > I updated the webrev with a fix by Martin Doerr, that fixes an
> > assertion showing on single processor machines.
> > Could I please get reviews?
> > http://cr.openjdk.java.net/~goetz/wr16/8169317-s390_fixes/webrev-02/
> >
> > @Shahid, this contains the fix Martin sent you, could you confirm that
> > this helps with your issue?
> >
> > Best regards,
> >  Goetz.
> >
> > > -----Original Message-----
> > > From: Lindenmaier, Goetz
> > > Sent: Montag, 7. November 2016 12:53
> > > To: hotspot-compiler-dev at openjdk.java.net
> > > Cc: Cindy Lee <cinderel at ca.ibm.com>; Amod Borkar
> > > <aborkar at us.ibm.com>; Shahid Shaikh <shahid at us.ibm.com>
> > > Subject: RFR: 8169317: [s390] Various minor bug fixes and adaptions.
> > >
> > > Hi,
> > >
> > >
> > >
> > > This change contains a row of minor fixes to the s390 port.
> > >
> > > Please review this change:
> > >
> > > http://cr.openjdk.java.net/~goetz/wr16/8169317-s390_fixes/webrev-01/
> > >
> > >
> > >
> > > The fixes in detail:
> > >
> > >
> > > s390.ad
> > > Fix rule indexOfChar_U.
> > >
> > > c1_LIRAssembler_s390.cpp
> > > Register overwritten in heap based compressed oops mode. We never
> > > see this mode on our systems, but it is a possible configuration.
> > >
> > > templateTable_s390.cpp, nativeInst_s390.cpp:
> > > Wrong register passed as argument to call_VM
> > >
> > > frame_s390.cpp, frame_s390.inline.hpp. os_linux_s390.cpp Some
> > > adaptions for "8151956: Support non-continuous CodeBlobs in HotSpot"
> > >
> > > Remove flag UseCountLeadingZerosInstruction. This instruction is
> > > available on all supported s390 cpus, and the tests for this flag
> > > depend on a string in the x86 cpu feature list.
> > >
> > > vm_version_s390.cpp
> > > Add 'aes' and 'sha' to cpu feature string if the corresponding
> > > extensions are implemented on the current cpu. Needed for jtreg tests.
> > >
> > > os_linux_s390.cpp
> > > Fix frame popping for debug / fastdebug build. Else NMT tests fail.
> > >
> > >
> > >
> > > Best regards,
> > >
> > >   Goetz.
> >
> >
> >
> 
> 
>