[9] RFR(XS): 8169941: CodeBlob::is_frame_complete_at() does not honor CodeOffsets::frame_never_safe

[dean.long at oracle.com]

+1

dl


On 11/18/16 8:53 AM, Vladimir Kozlov wrote:
> Good.
>
> Thanks,
> Vladimir
>
> On 11/18/16 3:43 AM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8169941
>> http://cr.openjdk.java.net/~thartmann/8169941/webrev.00/
>>
>> CodeBlob::is_frame_complete_at() should always return false if 
>> _frame_complete_offset is set to CodeOffsets::frame_never_safe (-1). 
>> Otherwise we may crash during profiling because 
>> frame::safe_for_sender() returns true for an unsafe runtime stub 
>> frame (see JDK-8169654).
>>
>> Tested with JPRT and RBT (running).
>>
>> Thanks,
>> Tobias
>>