RFR(S): 8168341: Gtests on JSon produce an enormous amount of hardly understandable output to stdout
Pavel Punegov
pavel.punegov at oracle.com
Tue Nov 29 13:24:01 UTC 2016
I don’t think we need to do a separate webrev for that.
— Thanks,
Pavel Punegov
> On 29 Nov 2016, at 15:57, Kirill Zhaldybin <kirill.zhaldybin at oracle.com> wrote:
>
> Pavel,
>
> Nice catch, thank you!
> I will fix it before push.
> Could you please let me know if you want separate review for it?
>
> Regards, Kirill
>
> On 29.11.2016 15:50, Pavel Punegov wrote:
>> Kirill,
>>
>> lines 31 and 35 have different alignment. Otherwise looks good.
>>
>> — Thanks,
>> Pavel Punegov
>>
>>> On 29 Nov 2016, at 14:58, Kirill Zhaldybin
>>> <kirill.zhaldybin at oracle.com <mailto:kirill.zhaldybin at oracle.com>> wrote:
>>>
>>> Dear all,
>>>
>>> I found (unfortunately a bit late) that stringStream requires
>>> ResourceMark.
>>>
>>> Here are a new WebRev:
>>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8168341/webrev.01/
>>> The only differences are added resource mark, #include
>>> "memory/resourceArea.hpp" and fixed indents.
>>>
>>> Could you please let me know your opinion?
>>>
>>> Thank you.
>>>
>>> Regards, Kirill
>>>
>>> On 25.11.2016 21:12, Kirill Zhaldybin wrote:
>>>> Dear all,
>>>>
>>>> Could you please review this fix for 8168341?
>>>>
>>>> I redirected output to stringStream instead of tty and appended it to an
>>>> assert message in case of failure.
>>>>
>>>> WebRev:
>>>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8168341/webrev.00/
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8168341
>>>>
>>>> Thank you.
>>>>
>>>> Regards, Kirill
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20161129/36495c70/attachment.html>
More information about the hotspot-compiler-dev
mailing list